How to reset the player's sound to normal on player_blind?

[Mahi]

*Edit: we are working on a couple new decorators that will allow you to hook these types of functions once an entity of the specified type is created on the server. There is still a lot of work to do on it, though. The usage of these decorators 'might' end up looking something like this:

Syntax: Select all

from entities.hooks import EntityPreHook


@EntityPreHook('player', 'deafen')
def pre_deafen(args):
    ...

Please, please, please, please, YES! :D

When I first saw Source.Python, I thought it's just an other shitty addon which will never see the daylight. I was wrong, this has got to be one of the best things that have ever happened to the CS community!

I can't wait for SP to reach its final version, even though that's still quite far away. Huge thanks to all the SP developers, you're doing one hell of a job, keep on rolling guys! :)

[BackRaw]

Yep, it does.

https://github.com/backraw/backraw.sp/blob/master/addons/source-python/plugins/flashfunsp/hooks.py works like a charm! Thanks very much guys

[Ayuto]

We have just added the entity hook decorators!
https://github.com/Source-Python-Dev-Team/Source.Python/commit/7482638e2d39e6cd5d7538d7e7b710fad6a674fd

[BackRaw]

We have just added the entity hook decorators!
https://github.com/Source-Python-Dev-Team/Source.Python/commit/7482638e2d39e6cd5d7538d7e7b710fad6a674fd

Awesome job!

[satoon101]

Does return 0 i the pre-hook block the defean function?

You should really use False instead of 0. Actually, I thought we had an enum that we used to block or continue, but I can't find it so maybe we don't.

[L'In20Cible]

There is no enum as the returned value of the callback override the real one (if not None).

[satoon101]

I think that is only true of post hooks. But even with post hooks you modify the return_value argument instead of returning a value. With pre hooks, you just return False to block the function or modify one of the arguments passed to change the behavior during the function call.

[Ayuto]

No, L'In20Cible is right. Here is the proof. https://github.com/Source-Python-Dev-Team/Source.Python/blob/master/src/core/modules/memory/memory_hooks.cpp#L124

If you would just return True or False in a PreHook, what would be the return value for the caller?

[L'In20Cible]

I think you are mixing SPE syntax which used to be:

Syntax: Select all

return (HookAction.Continue/Override, <overriden return value>)

Which was kinda pointless, as if you return anything, you want it to be overriden.

[satoon101]

Yeah, I think I am too. I really gotta stop replying while I am at work...

[BackRaw]

Any updates on this - return something or change an argument?

[satoon101]

What exactly are you asking about here, specifically? I did notice in your repository that you block both the deafen and the blind, though you do it very strangely in the blind hook. All you have to do is return False to block the blinding. However, if you want to block both blind and deafen, all you really need to do is block the CFlashbangProjectile::Detonate member function:

Syntax: Select all

@EntityPreHook(EntityCondition.equals_entity_classname('flashbang_projectile'), 'detonate')
def pre_flashbang_detonate(args):
    return False

This will also fix everything in this comment I noticed in your code:
https://github.com/backraw/backraw.sp/blob/master/flashfunsp/flashfunsp.py#L204

Syntax: Select all

# In actuality, the player will still get blinded, but they won't
    # notice it. The only 'bug' here is that, if they look at the
    # detonating grenade, they still see a little explosion.
    # I'm not quite sure yet, whether I should leave it like that or try
    # to fix it.

Off topic: I have noticed that instead of just updating your repository, you have a tendency to remove the repository completely and start fresh every time you work on it. That sort of defeats part of the purpose of a version control system. I also prefer to have each of my plugins in their own repository instead of one all-encompassing repo, as that is easier for others to post issues and pull requests to and helps keep it a lot more organized.

[BackRaw]

What exactly are you asking about here, specifically? I did notice in your repository that you block both the deafen and the blind, though you do it very strangely in the blind hook. All you have to do is return False to block the blinding. However, if you want to block both blind and deafen, all you really need to do is block the CFlashbangProjectile: :D etonate member function:

Syntax: Select all

@EntityPreHook(EntityCondition.equals_entity_classname('flashbang_projectile'), 'detonate')
def pre_flashbang_detonate(args):
    return False

This will also fix everything in this comment I noticed in your code:
https://github.com/backraw/backraw.sp/blob/master/flashfunsp/flashfunsp.py#L204

Syntax: Select all

# In actuality, the player will still get blinded, but they won't
    # notice it. The only 'bug' here is that, if they look at the
    # detonating grenade, they still see a little explosion.
    # I'm not quite sure yet, whether I should leave it like that or try
    # to fix it.

Thanks!! That's what I need. I asked because there is no return_type in the entities/orangebox/cstrike/CCSPlayer.ini data file:

Syntax: Select all

[[deafen]]
    identifier_windows = 55 8B EC 83 EC 28 89 4D FC 8B 45 FC 8B 10
    identifier_linux = _ZN9CCSPlayer6DeafenEf
    arguments = FLOAT

Off topic: I have noticed that instead of just updating your repository, you have a tendency to remove the repository completely and start fresh every time you work on it. That sort of defeats part of the purpose of a version control system. I also prefer to have each of my plugins in their own repository instead of one all-encompassing repo, as that is easier for others to post issues and pull requests to and helps keep it a lot more organized.

The old repository was messed up and I'm using a different IDE now. Sorry about that.

[satoon101]

Thanks!! That's what I need. I asked because there is no return_type in the entities/orangebox/cstrike/CCSPlayer.ini data file:

Syntax: Select all

[[deafen]]
    identifier_windows = 55 8B EC 83 EC 28 89 4D FC 8B 45 FC 8B 10
    identifier_linux = _ZN9CCSPlayer6DeafenEf
    arguments = FLOAT

There is no return type for that function, it's a void. But you have to return something in the pre-hook to block the function from firing.

The old repository was messed up and I'm using a different IDE now. Sorry about that.

No need to apologize, I just found it a bit odd. Do what you want to do, it just defeated one of the primary purposes of having an online repository and version control system.

[Ayuto]

But you have to return something in the pre-hook to block the function from firing.

Something that is not None. :P

As a reminder for everyone: If a function has a return type that is not "void", you need to return a value of that type to block the original function. If it's a void function, you can return anything that is not None (True, False, 0, 1, 2, object, what ever).

[BackRaw]

Thank you for craifying!

No need to apologize, I just found it a bit odd. Do what you want to do, it just defeated one of the primary purposes of having an online repository and version control system.

Yes, you're right and I know that.