Source.Python forums

Creating an entity with Entity.create('classname') followed by making a weapon entity from that entity's index, then setting the weapon's origin to the players origin, then spawning it, then setting it as the player's active weapon. Such as:



Syntax: Select all

@TypedSayCommand('!awp')
@TypedClientCommand('sp_awp')
def give_awp(command):
    player = Player(command.index)
    if player.primary:
        current_weapon = player.primary
        player.drop_weapon(current_weapon.pointer, NULL_VECTOR, NULL_VECTOR)
        current_weapon.remove()
    awp_base = Entity.create('weapon_awp')
    awp = Weapon(awp_base.index)
    awp.origin = player.origin
    awp.spawn()
    player.set_active_weapon(awp)
    return CommandReturn.BLOCK



I feel this is probably a poor way of doing it. However, I have also tried creating the weapon via player.give_named_item('classname'). For example:



Syntax: Select all

@TypedSayCommand('!scout')
@TypedClientCommand('sp_scout')
def give_scout(command):
    player = Player(command.index)
    if player.primary:
        current_weapon = player.primary
        player.drop_weapon(current_weapon.pointer, NULL_VECTOR, NULL_VECTOR)
        current_weapon.remove()
    player.give_named_item('weapon_scout')
    new_weapon = player.primary
    player.set_active_weapon(new_weapon)
    return CommandReturn.BLOCK



I feel this is probably a poor way of doing it as well, and it doesn't work well for my implementation because it relies on player.primary and player.secondary to build the weapon object, making it impossible (from my understanding) to use this system for knife (which i have made droppable) and grenades.

Finally, I have tried making the weapon with make_object and player.give_named_item('classname'), a la:



Syntax: Select all

@TypedSayCommand('!ak47')
@TypedClientCommand('sp_ak47')
def give_ak47(command):
    player = Player(command.index)
    if player.primary:
        current_weapon = player.primary
        player.drop_weapon(current_weapon.pointer, NULL_VECTOR, NULL_VECTOR)
        current_weapon.remove()
    ak47 = make_object(Weapon, player.give_named_item('weapon_ak47'))
    player.set_active_weapon(ak47)
    return CommandReturn.BLOCK



This seems like the best compromise. However, it still has the same issue as the other two methods. In all three methods, in some cases, particularly when spawning a secondary weapon (all of the examples i've given so far are primaries, but I have the correct checks in place for secondaries (i think), check the files below) the weapon model isn't updated until the player does an action with the new weapon.

@ClientCommand('drop')
def drop_knife(command, pindex):
    player = Player(pindex)
    weapon = player.get_active_weapon()
    if weapon.weapon_name == "weapon_knife":
        player.drop_weapon(weapon.pointer, player.view_vector, NULL_VECTOR)
        weapon.remove()

taifuhime wrote:Last question for now: I mentioned earlier that I made knives droppable. There is a small issue with that as well. I'm using this code snippet which I believe I found somewhere on the forums. I may or may not have modified it, I cannot remember. Anyhow:

Syntax: Select all

@ClientCommand('drop')
def drop_knife(command, pindex):
    player = Player(pindex)
    weapon = player.get_active_weapon()
    if weapon.weapon_name == "weapon_knife":
        player.drop_weapon(weapon.pointer, player.view_vector, NULL_VECTOR)
        weapon.remove()

The issue with this is that when the knife is dropped, it drops another weapon alongside it. So, when you drop the knife it will get dropped (and subsequently removed) and another weapon would get dropped on the floor. This isn't that big of a deal since most people who are dropping knives are dropping all of their weapons regardless, but I'm still interested in why this happens.

satoon101 wrote:

taifuhime wrote:Last question for now: I mentioned earlier that I made knives droppable. There is a small issue with that as well. I'm using this code snippet which I believe I found somewhere on the forums. I may or may not have modified it, I cannot remember. Anyhow:

Syntax: Select all

@ClientCommand('drop')
def drop_knife(command, pindex):
    player = Player(pindex)
    weapon = player.get_active_weapon()
    if weapon.weapon_name == "weapon_knife":
        player.drop_weapon(weapon.pointer, player.view_vector, NULL_VECTOR)
        weapon.remove()

The issue with this is that when the knife is dropped, it drops another weapon alongside it. So, when you drop the knife it will get dropped (and subsequently removed) and another weapon would get dropped on the floor. This isn't that big of a deal since most people who are dropping knives are dropping all of their weapons regardless, but I'm still interested in why this happens.

I cannot respond to the rest of your post at this time, but I believe why this specific issue happens is because you are not returning CommandReturn.BLOCK. Therefor, after you drop the knife, a new weapon is now your 'active' weapon, and the client command 'drop' is executed, which will drop your now active weapon.

L'In20Cible wrote:Your code could be something like the following:

Syntax: Select all

# ../addons/source-python/weapons/weapons.py

# ============================================================================
# >> IMPORTS
# ============================================================================
# Source.Python Imports
#   Commands
from commands import CommandReturn
from commands.client import ClientCommand
from commands.say import SayCommand
#   Players
from players.entity import Player
#   Weapons
from weapons.manager import weapon_manager


# ============================================================================
# >> GLOBAL VARIABLES
# ============================================================================
# Build a list of weapons without prefix
weapons = [weapon.replace(weapon_manager.prefix,
    str()) for weapon in weapon_manager]
    
    
# ============================================================================
# >> COMMANDS
# ============================================================================
@ClientCommand(['sp_' + weapon for weapon in weapons])
@SayCommand(['!' + weapon for weapon in weapons])
def _weapon_commands_callback(command, player_index, team_only=False):
    """Called when a !<weapon> command is typed in chat or a sp_<weapon>
       command is typed in console.
    """
    # Get a Player instance of the player issuing the command
    player = Player(player_index)
    
    # If the player is dead, just exit the function early
    if player.dead:
        return CommandReturn.BLOCK
        
    # Get the name of the weapon to give
    name = weapon_manager.prefix + command.command_string.lstrip(
        '!').replace('sp_', str()).lower().strip()
        
    # Get the slot of the weapon we are giving
    slot = weapon_manager[name].slot
    
    # Loop through all weapons currently owned by the player
    for weapon in player.weapons():
        
        # Skip the current weapon if it isn't in the same slot as the weapon
        #   we are giving
        if weapon_manager[weapon.classname].slot != slot:
            continue
            
        # Remove the current weapon
        weapon.remove()
        
    # Give the weapon to the player and switch to it
    player.weapon_switch(player.give_named_item(name), 0)
    
    # Block the command
    return CommandReturn.BLOCK

satoon101 wrote:A couple other minor optimizations from that code:

Technically, using the prefix would break for some other games where the prefix is not always used/consistent. Plus, we already have access to the name without any prefix, so why bother.

Syntax: Select all

# Build a list of weapons without prefix
weapons = [weapon.basename for weapon in weapon_manager]

satoon101 wrote:Using weapon_manager.__getitem__ already handles the prefix properly for us, including "special_names", which would be the ones that above would not contain the consistent prefix.

Syntax: Select all

# Get the name of the weapon to give
    name = command.command_string.lstrip(
        '!').replace('sp_', str()).lower().strip()

L'In20Cible wrote:Your code could be something like the following:

Syntax: Select all

# ../addons/source-python/weapons/weapons.py

# ============================================================================
# >> IMPORTS
# ============================================================================
# Source.Python Imports
#   Commands
from commands import CommandReturn
from commands.client import ClientCommand
from commands.say import SayCommand
#   Players
from players.entity import Player
#   Weapons
from weapons.manager import weapon_manager


# ============================================================================
# >> GLOBAL VARIABLES
# ============================================================================
# Build a list of weapons without prefix
weapons = [weapon.basename for weapon in weapon_manager.values()]


# ============================================================================
# >> COMMANDS
# ============================================================================
@ClientCommand(['sp_' + weapon for weapon in weapons])
@SayCommand(['!' + weapon for weapon in weapons])
def _weapon_commands_callback(command, player_index, team_only=False):
    """Called when a !<weapon> command is typed in chat or a sp_<weapon>
       command is typed in console.
    """
    # Get a Player instance of the player issuing the command
    player = Player(player_index)
    
    # If the player is dead, just exit the function early
    if player.dead:
        return CommandReturn.BLOCK
        
    # Get the data of the weapon to give
    data = weapon_manager[command.command_string.lstrip('!').replace(
        'sp_', str()).lower().strip()]
        
    # Loop through all weapons currently owned by the player
    for weapon in player.weapons():
        
        # Skip the current weapon if it isn't in the same slot as the weapon
        #   we are giving
        if weapon_manager[weapon.classname].slot != data.slot:
            continue
            
        # Remove the current weapon
        weapon.remove()
        
    # Give the weapon to the player and switch to it
    player.weapon_switch(player.give_named_item(data.name), 0)
    
    # Block the command
    return CommandReturn.BLOCK