Multiple buffs/debuffs with various times

[arawra]

As a continuation of my other thread, I would like to create a timer for various effects for players. Effects include things like healing, poisons, slows, etc etc. I think I've found an effective way to accomplish this and would like input on my implementation and API.

Syntax: Select all

statusEffectsList = ['drug','regen','stun']
statusEffects = {}
for status in statusEffectsList:
    statusEffects[status] = []
    
def heal(player, amount):
    # player is a PlayerEntity/dndPlayer object
    player.health += amount
    if player.health > player.maxhp:
        player.health = player.maxhp
        
def stun():
    raise NotImplementedError('Not yet included')
    
def drug():
    raise NotImplementedError('Not yet included') 
        
def dndTick():
    for players in PlayerGenerator():
        myPlayer = dndPlayerDictionary[userid_from_playerinfo(players)]
        if not myPlayer.isdead:
            for item in myPlayer.statusEffects:
                for instance in myPlayer.statusEffects[item]
                
                    if myPlayer.statusEffects[item][instance]['effect']:
                        if dndTimer.count >= myPlayer.statusEffects[item][instance]['duration'] and dndTimer.count % myPlayer.statusEffects[item][instance]['duration'] == 0:
                            
                            if myPlayer.statusEffects[item][instance]['iteration'] != None 
                                if myPlayer.statusEffects[item][instance]['iteration'] > 0:
                                    myPlayer.statusEffects[item][instance]['iteration'] -= 1
                                    globals()[item]()
                                else:
                                    myPlayer.statusEffects[item][instance].pop
                            else:
                                globals()[item]()
                
@Event
def player_spawn(game_event):
    dndTimer.reset()
    
    spawnee_userid = game_event.get_int('userid')
    spawnee = dndPlayerDictionary[spawnee_userid]
    
    #This just sets all attributes of PlayerEntity() to their default value, i.e. max health is 100 and speed is 100%
    #dndPlayer object also has an attribute of statusEffects and dndPlayer.reset sets all keys to an empty list
    spawnee.reset()
    
    if spawnee.someAttribute = True:
        
        #Player should regenerate 1 health every 4 seconds
        spawnee.statusEffects['regen'].append({'duration':3,'effect':5,'intervals':3})
        
        #Player should regenerate 5 health every 3 seconds, but only for 3 intervals
        spawnee.statusEffects['regen'].append({'duration':3,'effect':5,'intervals':3})
            
dndTimer = TickRepeat(dndTick)
dndTimer.start(1,0)

[L'In20Cible]

I didn't check the entire code but something I noticed.

Syntax: Select all

def dndTick():
    for players in PlayerGenerator():
        myPlayer = dndPlayerDictionary[userid_from_playerinfo(players)]
        if not myPlayer.isdead:

Why not using PlayerIter?

Syntax: Select all

from filters.players import PlayerIter

def dndTick():
    for userid in PlayerIter('alive', return_types='userid'):
        myPlayer = dndPlayerDictionary[userid]

[satoon101]

Also, instead of making functions where you pass the player's instance, I would rather extend the player class to include the functions as methods. I will try to remember to provide an example when I get home tonight.

[Mahi]

As satoon mentioned, you should extend PlayerEntity class for something like this.

Syntax: Select all

def heal(player, amount):
    # player is a PlayerEntity/dndPlayer object
    player.health += amount
    if player.health > player.maxhp:
        player.health = player.maxhp

Can be turned into:

Syntax: Select all

class DndPlayer(PlayerEntity):
    """DndPlayer extends PlayerEntity to implement bonus effects like healing."""

    def heal(self, amount):
        """Heals player for 'amount' health."""
        self.health += amount
        if self.health > self.maxhp:
            self.health = self.maxhp

And now instead of using PlayerEntity, you use DndPlayer and just say

Syntax: Select all

my_player = DndPlayer(player_index)
my_player.heal(15)

Now you can fill your dndPlayerDictionary with DndPlayers, or if it's already filled with some custom class that needs to work in a different way than PlayerEntity class does (f.e. sustain through deaths etc.), you can just add a 'get_entity' method, or similar, into the other class.

[arawra]

If I were to implement the methods as part of the class, could I call them using a variable as such?

Syntax: Select all

globals()[myPlayer.item]()

[satoon101]

More like:

Syntax: Select all

getattr(myPlayer, item)()