Quakesounds

[cssbestrpg]

https://github.com/srpg/quakesounds

[Sam]

Tip: soundlib -> engines.sound.Sound

[Painkiller]

Nice to see that there are now also some for SP.

High praise

little things I noticed:

Headshot, Teamkill for teamdeathmatch, Multikill ,humiliation, suizide are things that are very interesting but unfortunately missing.

Maybe you still have the desire to add to this.

Greeting Painkiller

[cssbestrpg]

Some point i could add missing sounds

So far now:

Added now humiliation sound when knife kill
Added multikill sound
Added headshot sound

[Painkiller]

I will test it in the next days on a separate server and let you know.

[Painkiller]

Hello mate, a friend tested the plugin and this is the first bug he noticed.

Code: Select all

2020-05-27 10:11:19 - sp   -   MESSAGE   [SP] Successfully loaded plugin 'quakesound'.
2020-05-27 10:14:14 - sp   -   EXCEPTION   
[SP] Caught an Exception:
Traceback (most recent call last):
  File "..\addons\source-python\packages\source-python\events\listener.py", line 92, in fire_game_event
    callback(game_event)
  File "..\addons\source-python\plugins\quakesound\quakesound.py", line 61, in player_death
    if int(args['headshot']):

Code: Select all

2020-05-27 10:15:16 - sp   -   EXCEPTION   
[SP] Caught an Exception:
Traceback (most recent call last):
  File "..\addons\source-python\packages\source-python\events\listener.py", line 92, in fire_game_event
    callback(game_event)
  File "..\addons\source-python\plugins\quakesound\quakesound.py", line 61, in player_death
    if int(args['headshot']):

KeyError: "Key 'headshot' does not exist."

[cssbestrpg]

Can he test now? i made possible fix for headshot

[Painkiller]

This come now.

[Ayuto]

Can he test now? i made possible fix for headshot

This won't really fix the issue in HL2DM. It now just uses a default value (0) if the key "headshot" wasn't found (HL2DM doesn't provide a headshot key in the event player_death). You need to check the player's last hitgroup:

Syntax: Select all

from events import Event
from players.entity import Player
from players.constants import HitGroup

@Event('player_death')
def on_player_death(event):
    player = Player.from_userid(event['userid'])
    if player.last_hitgroup == HitGroup.HEAD:
        # Your code...
        print('Headshot')

[cssbestrpg]

Now updated the code, thanks Ayuto, i didn't know was HL2DM, i did make the code for css orginaly

[Painkiller]

Thanks a lot it will be tested again.

It is always nice to have quake sounds for several games and not just for one specific game.

Code: Select all

2020-05-28 14:24:18 - sp   -   MESSAGE   [SP] Loading plugin 'quakesound'...
2020-05-28 14:24:18 - sp   -   WARNING   
[SP] Encountered a Warning:
  File '..\addons\source-python\packages\site-packages\path.py', line 1713: DeprecationWarning
    path is deprecated. Use Path instead.

2020-05-28 14:24:18 - sp   -   MESSAGE   [SP] Successfully loaded plugin 'quakesound'.

[cssbestrpg]

The warning error can ignore, did the all sounds work? specially the headshot one?

[Painkiller]

My mate, says no sound plays.

[L'In20Cible]

There is a missing = on this line: ../quakesound.py#L74

[cssbestrpg]

Fixed now missing =

[Ayuto]

I guess I worked too much with another language lately (I also used the pipe (|) as a comment...)

[Painkiller]

Works now.

[cssbestrpg]

Added now suicide sound

[daren adler]

I get this

Code: Select all

2020-12-22 16:12:13 - sp   -   MESSAGE   [SP] Loading plugin 'quakesound'...
2020-12-22 16:12:13 - sp   -   WARNING   
[SP] Encountered a Warning:
  File '..\addons\source-python\packages\site-packages\path.py', line 1713: DeprecationWarning
    path is deprecated. Use Path instead

It dont crash,,i just seen it while cleaning up.

[satoon101]

That's just a warning, so nothing to be concerned about. The plugin can be updated to use path.Path instead of path.path to fix that warning. In future versions of the path package, they did remove path.path. I'm not sure if/when we'll update the SP version of that package, but if/when we do, it will break any plugins that use path.path.